[v2] Disperser API Server Entrypoint #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be merged on top of #784 |
ian-shim
changed the title
cody-littley
approved these changes
Oct 9, 2024
| return errors.New("could not start tcp listener") | ||
| } | ||
|
|
||
| opt := grpc.MaxRecvMsgSize(1024 * 1024 * 300) // 300 MiB |
There was a problem hiding this comment.
Should this be configurable?
There was a problem hiding this comment.
Yeah it probably should be. Maybe this should be maxBlobSize + some buffer. @mooselumph @bxue-l2 wdyt?
There was a problem hiding this comment.
I'll leave it the same as current disperser for now. I don't think there is a big risk here - we can revisit this later
Comment on lines
+66
to
+72
| DisperserVersionFlag = cli.UintFlag{ | ||
| Name: common.PrefixFlag(FlagPrefix, "disperser-version"), | ||
| Usage: "Disperser version. Options are 1 and 2.", | ||
| Required: false, | ||
| Value: 1, | ||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "DISPERSER_VERSION"), | ||
| } |
There was a problem hiding this comment.
We should have a discussion about configuration, I've got a proposal on how we might do it with less boilerplate like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Scaffolding v2 dispersal server
Checks