[node] Refactor blob expiration key #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
node-blob-expiration-key
branch
3 times, most recently
from
d7ee272 to
80daa58
Compare
ian-shim
force-pushed
the
node-blob-expiration-key
branch
from
80daa58 to
d35f068
Compare
mooselumph
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Instead of representing blob expiration value as a slice of blob header hashes, make each expiration key encode blob header hash so it represents expiration for a single blob.
Context: #676 (comment)
To be merged on top of #676
Checks