Make "retriever" spelling consistent everywhere. (RETRIVER --> RETRIEVER) (RETREIVER --> RETRIEVER) #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
May 17, 2024
| @@ -47,7 +47,7 @@ var ( | |||
| Name: common.PrefixFlag(FlagPrefix, "bls-operator-state-retriever"), | |||
| Usage: "Address of the BLS Operator State Retriever", | |||
| Required: true, | |||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "BLS_OPERATOR_STATE_RETRIVER"), | |||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "BLS_OPERATOR_STATE_RETRIEVER"), | |||
There was a problem hiding this comment.
Such change will break the users who are running this
There was a problem hiding this comment.
currently it also breaks new users, who expect a consistent spelling. What's the best way to proceed to consistency?
There was a problem hiding this comment.
I wouldn't say it "break" new users, although it may create some confusion with wrong spelling.
A proper way should consider backward compatibility and allow a smooth migration.
There was a problem hiding this comment.
Agreed, please take over this PR and fix it the right way. As an operator, I'd like consistency for downstream usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks