Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set all metrics to 0 for unregistered quorums #524

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Apr 26, 2024

Why are these changes needed?

  • Currently if someone deregisters then the metrics for rank and stake share are set to previous value. Which doesn't help operators with real data and they see wrong graph
  • This way we set those unregistered operator metrics to 0.
  • When node restarts all the metrics will be cleared and cache will build again

please verify if logic looks sane

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

node/metrics.go Outdated Show resolved Hide resolved
node/metrics.go Show resolved Hide resolved
@shrimalmadhur shrimalmadhur requested a review from jianoaix April 26, 2024 19:05
node/metrics.go Show resolved Hide resolved
node/metrics.go Show resolved Hide resolved
@shrimalmadhur shrimalmadhur requested a review from jianoaix April 26, 2024 21:29
@shrimalmadhur shrimalmadhur merged commit 1725e3b into master Apr 26, 2024
6 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/fix-unregistered-metrics branch April 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants