Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update log message to avoid confusion #139

Merged
merged 9 commits into from
Dec 20, 2023
Merged

chore: update log message to avoid confusion #139

merged 9 commits into from
Dec 20, 2023

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Dec 20, 2023 •
edited
Loading

Why are these changes needed?

The current log message in node confuses operator since it says that you are not opted-in even though you are opted-in via operator setup steps.

  • Updating the log message to be clear on what the call to action is
  • Adding chain specific log message

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@shrimalmadhur shrimalmadhur changed the title update log message to avoid confusion chore: update log message to avoid confusion Dec 20, 2023
jianoaix
jianoaix reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/node.go Outdated Show resolved Hide resolved
shrimalmadhur
shrimalmadhur commented Dec 20, 2023
View reviewed changes
node/node.go Outdated Show resolved Hide resolved
jianoaix
jianoaix reviewed Dec 20, 2023
View reviewed changes
node/node.go Outdated Show resolved Hide resolved
jianoaix
jianoaix approved these changes Dec 20, 2023
View reviewed changes
node/node.go Show resolved Hide resolved
@shrimalmadhur shrimalmadhur merged commit ee891ca into master Dec 20, 2023
5 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/fix-logs-msg branch December 20, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@victorfrancax1 victorfrancax1 victorfrancax1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrimalmadhur @victorfrancax1 @jianoaix