Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global symbols per period and interval #1033

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 19, 2024

Why are these changes needed?

quick fixes related to global reservations

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen mentioned this pull request Dec 19, 2024
5 tasks
@hopeyen hopeyen requested a review from ian-shim December 19, 2024 16:11
err := m.OffchainStore.RemoveOnDemandPayment(ctx, header.AccountID, header.CumulativePayment)
if err != nil {
return err
db_err := m.OffchainStore.RemoveOnDemandPayment(ctx, header.AccountID, header.CumulativePayment)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbErr

@hopeyen hopeyen merged commit 93caf91 into master Dec 19, 2024
9 checks passed
@hopeyen hopeyen deleted the hope/pmt-param-fix branch December 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants