init once accountant #1015
Merged
init once accountant #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hopeyen
force-pushed
the
hope/init-once-accountant
branch
from
ced7ab3 to
8b407c9
Compare
hopeyen
changed the base branch from
master
to
hope/payment-state-nil-handling
hopeyen
force-pushed
the
hope/payment-state-nil-handling
branch
from
1bb83ad to
0767072
Compare
hopeyen
force-pushed
the
hope/init-once-accountant
branch
2 times, most recently
from
cfcb6b2 to
a950bfb
Compare
|
42 file changes... maybe target branch needs to be rebased as well or something? |
Weird, this was supposed to be a single file change. taking a look now |
hopeyen
force-pushed
the
hope/init-once-accountant
branch
from
a950bfb to
6f95986
Compare
hopeyen
force-pushed
the
hope/init-once-accountant
branch
from
6f95986 to
efb9cf8
Compare
ian-shim
approved these changes
Dec 17, 2024
core/data.go
Outdated
| @@ -619,11 +619,27 @@ type ReservedPayment struct { | |||
| QuorumSplits []byte | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
we don't need this change right?
hopeyen
force-pushed
the
hope/init-once-accountant
branch
2 times, most recently
from
54a2645 to
73f2d9d
Compare
hopeyen
force-pushed
the
hope/init-once-accountant
branch
from
73f2d9d to
668fa2f
Compare
hopeyen
force-pushed
the
hope/init-once-accountant
branch
from
122d7a9 to
2fe2b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Instead of relying on disperser client to call populate accountant before dispersing blobs, we add an init once function that automatically populate the accountant if it isn't constructed at the beginning
Checks