Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint.yml #98

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update lint.yml #98

merged 1 commit into from
Aug 21, 2024

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Aug 21, 2024

Pull Request Template

Fixes Issue

Fixes #

Changes proposed

update golangci-lint github action to v6.
v3 uses a deprecated --out-format which was removed in v6.
See this run https://github.com/Layr-Labs/eigenda-proxy/actions/runs/10498975752/job/29084898659?pr=94 which is completely useless and doesn't show the actual error
image

Also removing the --verbose flag because it just adds a bunch of clutter which is not useful I find.
Compare:
image

Screenshots (Optional)

Note to reviewers

@samlaf samlaf requested a review from epociask August 21, 2024 23:35
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samlaf
Copy link
Collaborator Author

samlaf commented Aug 21, 2024

Merging. Will fix the lint issue in another PR.

@samlaf samlaf merged commit b88787d into main Aug 21, 2024
7 of 8 checks passed
@samlaf samlaf deleted the samlaf-patch-1 branch August 21, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants