Add badges for github actions #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
cody-littley
changed the title
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
bxue-l2
approved these changes
Aug 7, 2024
jianoaix
reviewed
Aug 8, 2024
epociask
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
LGTM - like how the use of badgs forces proper abstract segmentation of workflow jobs across files. Btw the test is failing due to a regression where forked PRs can't access the github env secrets predefined upstream (i.e, SIGNER_PRIVATE_KEY environment variable not set). This will pass once merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Fixes Issue
Add icons to eigenda-proxy landing page for github action status.
Changes proposed
Screenshots (Optional)
To see a view of the README file as it is in this branch, visit https://github.com/cody-littley/eigenda-proxy/tree/eigenda-proxy-badges?tab=readme-ov-file
Note to reviewers
Icons will not turn green until this merges and the tests run against master.