fix: Resolve commitment decoding bug #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
approved these changes
Aug 5, 2024
| @@ -260,6 +261,10 @@ func ReadCommitmentMode(r *http.Request) (commitments.CommitmentMode, error) { | |||
| if key == "" { // default | |||
| commit := path.Base(r.URL.Path) | |||
| if len(commit) > 0 && commit != "put" { // provided commitment in request params | |||
| if !strings.HasPrefix(commit, "0x") { | |||
There was a problem hiding this comment.
An related thing, when I use eigenda-proxy through curl. I have to put
127.0.0.1:3100/put/
If I miss the last "/", the eigenda-proxy would not be able to respond. Is it expected based on some standard, or something we can fix
There was a problem hiding this comment.
its expected based on a standard - given that client interactions are done programmatically its probably ok to keep it this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers