fix: change put route put/ -> put #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @karlb for review. Just applied the patch you had shared with me here. |
|
Not sure why the test is still failing. @karlb said he would take a look tomorrow. |
samlaf
commented
Oct 9, 2024
Comment on lines
+101
to
+105
| // we need to handle both: see https://github.com/ethereum-optimism/optimism/pull/12081 | ||
| // /put is for generic commitments, and /put/ for keccak256 commitments | ||
| // TODO: we should probably separate their handlers? | ||
| mux.HandleFunc("/put", WithLogging(WithMetrics(svr.HandlePut, svr.m), svr.log)) | ||
| mux.HandleFunc("/put/", WithLogging(WithMetrics(svr.HandlePut, svr.m), svr.log)) |
There was a problem hiding this comment.
@epociask can you review that this comment and the routes make sense. tests are passing but still want to be 100% certain since I still don't get our routing logic with the different paths. Should probably document this api at some point..
bxue-l2
approved these changes
Oct 11, 2024
|
|
||
| require ( | ||
| github.com/Layr-Labs/eigenda v0.8.4 | ||
| github.com/consensys/gnark-crypto v0.12.1 | ||
| github.com/ethereum-optimism/optimism v1.9.2 | ||
| github.com/ethereum/go-ethereum v1.14.8 | ||
| github.com/ethereum-optimism/optimism v1.9.4-0.20240927020138-a9c7f349d10b |
There was a problem hiding this comment.
@samlaf Remember to change to a canonical tag after 1.9.4 is released by OP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #88
Changes proposed
Screenshots (Optional)
Note to reviewers
Updated to optimism 1.9.3 which required also updating to go1.22