Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verifier srs flags paths #159

Merged
merged 2 commits into from
Sep 29, 2024
Merged

fix: verifier srs flags paths #159

merged 2 commits into from
Sep 29, 2024

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Sep 28, 2024

Made a mistake in #146

paths should have remained the same given that they are relative to where the binary is run from, not where the go file lives. Fixed and added a comment to that effect.

// in case we move this file around
Value: "../resources/g1.point",
// we use a relative path so that the path works for both the binary and the docker container
// aka we assume the binary is run from root dir, and that the resources/ dir is copied into the working dir of the container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought binary is run from the workdir, which is /app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s the binary in the container. By binary here I just meant if we make + .//bin/… or go run

Category: category,
},
&cli.StringFlag{
Name: CachePathFlagName,
Usage: "Directory path to SRS tables for caching.",
EnvVars: withEnvPrefix(envPrefix, "TARGET_CACHE_PATH"),
Value: "../resources/SRSTables/",
// we use a relative path so that the path works for both the binary and the docker container
// aka we assume the binary is run from root dir, and that the resources/ dir is copied into the working dir of the container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above,

@samlaf samlaf merged commit db9d13b into main Sep 29, 2024
5 checks passed
@samlaf samlaf deleted the fix--verifier-flag-path branch September 29, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants