Skip to content

Commit

Permalink
Chore give docker image fullname (#119)
Browse files Browse the repository at this point in the history
* chore: docker-build uses full ghcr image name

* chore: clean dockerignore file
  • Loading branch information
samlaf authored Sep 6, 2024
1 parent 473c880 commit f5a2813
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ COPY go.mod go.sum ./
# Download all dependencies. Dependencies will be cached if the go.mod and go.sum files are not changed
RUN go mod download

# Copy the rest of the application code
# Copy the rest of the application code (filtered by .dockerignore)
COPY . .

# Build the application binary
Expand Down
11 changes: 9 additions & 2 deletions Dockerfile.dockerignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
!/go.mod
!/go.sum
# Ignore everything
*

# Re-include necessary files only
!go.mod
!go.sum
!*/**/*.go
!Makefile
!resources
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
APP_NAME = eigenda-proxy
IMAGE_NAME = ghcr.io/layr-labs/eigenda-proxy
LINTER_VERSION = v1.52.1
LINTER_URL = https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh
GET_LINT_CMD = "curl -sSfL $(LINTER_URL) | sh -s -- -b $(go env GOPATH)/bin $(LINTER_VERSION)"
Expand All @@ -21,7 +21,7 @@ eigenda-proxy:

.PHONY: docker-build
docker-build:
@docker build -t $(APP_NAME) .
@docker build -t $(IMAGE_NAME) .

run-minio:
docker run -p 4566:9000 -d -e "MINIO_ROOT_USER=minioadmin" -e "MINIO_ROOT_PASSWORD=minioadmin" --name minio minio/minio server /data
Expand Down

0 comments on commit f5a2813

Please sign in to comment.