Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade eigenda image #21

Merged
merged 2 commits into from
Dec 15, 2023
Merged

upgrade eigenda image #21

merged 2 commits into from
Dec 15, 2023

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Dec 14, 2023 •
edited
Loading

Updated graphs

Screenshot 2023-12-14 at 1 32 40 PM

24 hr screenshot
Screenshot 2023-12-15 at 11 08 03 AM

@shrimalmadhur shrimalmadhur marked this pull request as ready for review December 14, 2023 21:42
@shrimalmadhur shrimalmadhur changed the title [wip] upgrade eigenda image upgrade eigenda image Dec 14, 2023
@jianoaix
Copy link
Contributor

Hmm, I am still seeing issue in the graph, i.e. the num removed is greater than num processed

@jianoaix
Copy link
Contributor

Hmm, I am still seeing issue in the graph, i.e. the num removed is greater than num processed

I think I understand now: node_eigenda_processed_batches_total is tracking current incoming batches, whereas node_eigenda_removed_batches_total is tracking the removal of batches that are 14 days old. So this still doesn't align...

@shrimalmadhur
Copy link
Contributor Author

Hmm, I am still seeing issue in the graph, i.e. the num removed is greater than num processed

I think I understand now: node_eigenda_processed_batches_total is tracking current incoming batches, whereas node_eigenda_removed_batches_total is tracking the removal of batches that are 14 days old. So this still doesn't align...

yea - removal of old batches can be more than current processed right? is that not right?

@shrimalmadhur shrimalmadhur merged commit e936f58 into master Dec 15, 2023
@shrimalmadhur shrimalmadhur deleted the madhur/update-v0.1.3 branch December 15, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @jianoaix