Skip to content

Better layout comp #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2022
Merged

Better layout comp #128

merged 3 commits into from
Apr 3, 2022

Conversation

@lolipopshock
Copy link
Member

@lolipopshock lolipopshock commented Apr 2, 2022 •
edited
Loading

  1. Fix a bug that incorrectly compares two Layout objects
  2. Add type checking for Layout initialization, and it will convert tuple-like inputs to list to avoid possible bugs.

@lolipopshock
Copy link
Member Author

lolipopshock commented Apr 2, 2022

Fix #109

@lolipopshock lolipopshock merged commit 2b54450 into main Apr 3, 2022
@lolipopshock lolipopshock deleted the better-layout-comp branch April 3, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lolipopshock