feat: add branding metadata rawfile to generated zones - #944
Open
michaeloliverx wants to merge 3 commits into
Open
feat: add branding metadata rawfile to generated zones#944michaeloliverx wants to merge 3 commits into
michaeloliverx wants to merge 3 commits into
Conversation
michaeloliverx
commented
Jul 27, 2026
Laupetin
reviewed
Aug 7, 2026
| if constexpr (requires { rawFile->compressedLen; }) | ||
| rawFile->compressedLen = 0; | ||
|
|
||
| if constexpr (requires { rawFile->data.buffer; }) |
Owner
There was a problem hiding this comment.
TIL: you can do this... Oh wonders of modern c++.
Still a bit icky in bigger components over multiple games because its hard to debug which configuration gets what result 😅 but it's okay here i guess
Laupetin
reviewed
Aug 7, 2026
| { | ||
| const auto brandingText = CreateBrandingText(m_zone_definition, m_zone.m_name); | ||
| auto* rawFile = detail::CreateBrandingRawFile<typename Asset_t::Type, Compress>(m_memory, m_zone.m_name, brandingText); | ||
| context.AddAsset<Asset_t>(m_zone.m_name, rawFile); |
Owner
There was a problem hiding this comment.
This should probably check if such a file is already in the zone?
This current overwrites any rawfile with the same name.
It would probably be better to prioritize user input and assets over this branding file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #328
Example output:
Keys can be changed / discussed.