Skip to content

Addresess sortable table header accessibility issues. #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aalejandromr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Addresess sortable table header accessibility issues. #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions .storybook/styles/components/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,28 +64,32 @@ th {
opacity: 0.4;
}

&:hover:after {
content: '▼';
}
}

.order-ascend {
&:after {
content: '▲';
}

&:hover:after {
content: '▼';
button {
width: 100%;
cursor: pointer;
&:hover:after {
content: '▼';
}
}
}

.order-descend {
&:after {
content: '▼';
&.ascending {
button:after {
content: '▲';
}

button:hover:after {
content: '▼';
}
}

&:hover:after {
content: '▲';

&.descending {
button:after {
content: '▼';
}

button:hover:after {
content: '▲';
}
}
}

Expand Down
20 changes: 13 additions & 7 deletions src/tables/components/table-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,26 @@ function TableHeader({
onClick,
}) {
const active = sortPath === name
const arrowClass = getArrowClass(active, ascending)
const sortOrder = getSortOrder(active, ascending)
const headerProps = {}

if (active) {
headerProps['aria-sort'] = sortOrder
}

return (
<th
onClick={onClick}
className={classnames(arrowClass, { sortable: !disabled })}
className={classnames(sortOrder, { sortable: !disabled })}
{...headerProps}
>
{label || startCase(name)}
<button onClick={onClick}>{label || startCase(name)}</button>
</th>
)
}

function getArrowClass(active, ascending) {
if (!active) return ''
return ascending ? 'order-ascend' : 'order-descend'
function getSortOrder(active, ascending) {
if (!active) return undefined
return ascending ? 'ascending' : 'descending'
}

TableHeader.propTypes = propTypes
Expand Down