mcp: fix status() to not overwrite connected with failed#1
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MCP status showing servers as failed when connected
Summary
MCP.status()logic to avoid overwriting aconnectedstatus withfailed.gh_grepandchrome-devtoolsasfaileddespite being usable.Details
result[key] = "connected"when the client existed, but then immediately setresult[key] = "failed"unconditionally. Added acontinueto preserveconnected.Record<string, "connected" | "failed" | "disabled">, matching opencode-web's current expectations.opentuibranch returns{ name: { status } }. If/when we adopt that shape, we'll align the web client accordingly. For now, this PR fixes correctness without changing the API shape.Verification
/mcpdrives theMcpStatuscomponent. After this change, servers with active clients reportconnectedand render green.Upstream
opentuibranch appears to have addressed this; this fork PR ensures we are unblocked now while upstream changes land.