Skip to content

Update serialport dependency to use version 12.0.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update serialport dependency to use version 12.0.0 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"node-hid": "2.1.1",
"node-static": "*",
"request": "*",
"serialport": "9.x",
"serialport": "^12.0.0",
"socket.io": "4.x",
"ws": "8.x"
},
Expand Down
18 changes: 9 additions & 9 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@
*/

const config = require('./config');
const serialport = require('serialport');
var SerialPort = serialport;
const Readline = SerialPort.parsers.Readline;
const { SerialPort } = require('serialport');
const { ReadlineParser } = require('@serialport/parser-readline');
const websockets = require('socket.io');
const http = require('http');
const WebSocket = require('ws');
Expand Down Expand Up @@ -224,7 +223,7 @@ io.sockets.on('connection', function (appSocket) {
appSocket.emit('interfaces', supportedInterfaces);

// check available ports
serialport.list().then(ports => {
SerialPort.list().then(ports => {
portsList = ports;
let portPaths= new Array();
for (var i = 0; i < ports.length; i++) {
Expand All @@ -236,7 +235,7 @@ io.sockets.on('connection', function (appSocket) {
// reckeck ports every 2s
if (!listPortsLoop) {
listPortsLoop = setInterval(function () {
serialport.list().then(ports => {
SerialPort.list().then(ports => {
if (JSON.stringify(ports) != JSON.stringify(portsList)) {
portsList = ports;
io.sockets.emit('ports', portsList);
Expand Down Expand Up @@ -278,7 +277,7 @@ io.sockets.on('connection', function (appSocket) {
writeLog(chalk.yellow('INFO: ') + chalk.blue('FirstLoad called'), 1);
appSocket.emit('serverConfig', config);
appSocket.emit('interfaces', supportedInterfaces);
serialport.list().then(ports => {
SerialPort.list().then(ports => {
appSocket.emit('ports', ports);
});
if (isConnected) {
Expand Down Expand Up @@ -318,7 +317,7 @@ io.sockets.on('connection', function (appSocket) {

appSocket.on('getPorts', function () { // Refresh serial port list
writeLog(chalk.yellow('INFO: ') + chalk.blue('Requesting Ports list '), 1);
serialport.list().then(ports => {
SerialPort.list().then(ports => {
appSocket.emit('ports', ports);
});
});
Expand Down Expand Up @@ -382,10 +381,11 @@ io.sockets.on('connection', function (appSocket) {
firmware = false;
switch (connectionType) {
case 'usb':
port = new SerialPort(data[1], {
port = new SerialPort({
path: data[1],
baudRate: parseInt(data[2].replace('baud',''))
});
const parser = port.pipe(new Readline({ delimiter: '\n' }))
const parser = port.pipe(new ReadlineParser({ delimiter: '\n' }))
// parser.on('data', console.log) // uncomment to dump raw data from the connected port
io.sockets.emit('connectStatus', 'opening:' + port.path);

Expand Down