Improve windows module installer support #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== Third patch to gaiin Unity Hub parity for module installation. For windows it was necessary to implement other changes first to get to the point to savely implement the missing installer types. This patch adds the missing installer types: * zip * po * msi Zip --- Zip is used as for all other platforms. It invokes the shared cross platform implementation. MSI --- The `msi` installer is tricky. It seems to be used only by `Facebook Gameroom`. It seems Unity Hub expects a specigic `cmd` string to replace the installer path. I use the same trick as used with the `exe` installers by creating a temp `cmd` script which invokes the installer comand. At one point it might be worth investigating in a `CommandExt` to call the windows process in the correct way. Changes ======= ![ADD] ![WINDOWS] `zip` module installer support ![ADD] ![WINDOWS] `msi` module installer support ![ADD] ![WINDOWS] `po` language files installer support ![CHANGE] ![WINDOWS] installer API and support optional `cmd` string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third patch to gain Unity Hub parity for module installation. For windows it was necessary to implement other changes first to get to the point to safely implement the missing installer types.
This patch adds the missing installer types:
Zip
Zip is used as for all other platforms. It invokes the shared cross platform implementation.
MSI
The
msiinstaller is tricky. It seems to be used only byFacebook Gameroom. It seems Unity Hub expects a specigiccmdstring to replace the installer path. I use the same trick as used with theexeinstallers by creating a tempcmdscript which invokes the installer comand. At one point it might be worth investigating in aCommandExtto call the windows process in the correct way.Changes
zipmodule installer supportmsimodule installer supportpolanguage files installer supportcmdstring