Fix missing cmd property in modules #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== The `uvm_core::unity::Module` struct is missing the `cmd` property mainly used in windows. I added the property as `Option<Vec<OsString>>` to be directly used as an argument for the `std::process::Command.args` function. Changes ======= * ![FIX] missing `cmd` property in `uvm_core::unity::Module`
Larusso
force-pushed
the
fix/missing_cmd_property_in_modules
branch
from
e1e5de9 to
0c545ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
uvm_core::unity::Modulestruct is missing thecmdproperty mainly used in windows. Thecmdproperty from the ini files get converted once more before assigned to the module instances.Changes
cmdproperty inuvm_core::unity::Module