Refactor installer API #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== To support all new and old support modules I need to adjust the installer API. At the moment each module installation required a destination path for the installation. Sadly some modules only have no destination configured and either use a default value or none at all. That is a problem because validating which default value to use is platform and installer type specific. Which means that this can only be handled in the installer directly. I made the decision to change the API for `install_editor` and `install_module` to support an `Option<AsRef<Path>>` value. The installer will valid the destination and fail if a destination is required but not passed down. Changes ======= * ![CHANGE] installer API
Larusso
force-pushed
the
refactor/installer_api
branch
from
cb467e7 to
10bf384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support all new and old support modules I need to adjust the installer API. At the moment each module installation required a destination path for the installation. Sadly some modules only have no destination configured and either use a default value or none at all. That is a problem because validating which default value to use is platform and installer type specific. Which means that this can only be handled in the installer directly. I made the decision to change the API for
install_editorandinstall_moduleto support anOption<AsRef<Path>>value. The installer will valid the destination and fail if a destination is required but not passed down.Changes