Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12] Use str helper to render markdown #3795

Closed
wants to merge 1 commit into from
Closed

[v12] Use str helper to render markdown #3795

wants to merge 1 commit into from

Conversation

lakuapik
Copy link
Contributor

As shown in this old tweet https://twitter.com/taylorotwell/status/1355188002818035713, taylor otwell introducing Str::markdown use within laravel. This PR change markdown renderer from Maillable to Str class helper.

The helper was introduced here laravel/framework#36171 and released here https://github.com/laravel/framework/releases/tag/v8.26.0.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@lakuapik
Copy link
Contributor Author

also, considering the rendered output using github flavored markdown, is it necessary to add the stylesheet too?
will use this https://github.com/sindresorhus/github-markdown-css to style the outputed markdown to make it more beautiful.

@tabacitu
Copy link
Member

Totally - Str::markdown is much more intuitive, thank you @lakuapik . Unfortunately we'll only be able to merge this when we drop support for Laravel 6 and 7 (next major version) - because for those people this is a breaking change.

So we're totally going to merge this, but it's going to be a while.

Thank you @lakuapik !

@ziming
Copy link
Contributor

ziming commented Sep 4, 2021

oh wow my markdown column has changed so much since hehe

@tabacitu tabacitu removed the 4.2 label Oct 12, 2021
@tabacitu
Copy link
Member

On second thought, unfortunately we can't merge this into 4.2 either... Backpack 4.2 will require Laravel 8.x, which includes versions BEFORE 8.25, which won't have Illuminate\Support\Str::markdown()

I'll move this to the next version of Backpack, when we will only support Laravel 9.x - only then can we merge this, unfortunately... Compatibility is a b*1ch 😅

@lakuapik
Copy link
Contributor Author

@tabacitu i know your feelings, compatibility is s*cks 😆 😅

@tabacitu tabacitu changed the title Use str helper to render markdown [v12] Use str helper to render markdown Jan 3, 2022
@tabacitu tabacitu changed the base branch from master to 4.2 January 21, 2022 08:06
@tabacitu
Copy link
Member

@lakuapik I have great news. I've just merged this PR into #4102 and that one into 4.2. Since in 4.2 we require Laravel 8 or higher, it isn't a big thing to require 8.26 or higher. So this is merged through #4102 - even if here it'll show up as closed.

Thank youuu 🙏

@tabacitu tabacitu closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants