-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12] Use str helper to render markdown #3795
Conversation
The inspection completed: No new issues |
also, considering the rendered output using github flavored markdown, is it necessary to add the stylesheet too? |
Totally - So we're totally going to merge this, but it's going to be a while. Thank you @lakuapik ! |
oh wow my markdown column has changed so much since hehe |
On second thought, unfortunately we can't merge this into 4.2 either... Backpack 4.2 will require Laravel 8.x, which includes versions BEFORE 8.25, which won't have I'll move this to the next version of Backpack, when we will only support Laravel 9.x - only then can we merge this, unfortunately... Compatibility is a b*1ch 😅 |
@tabacitu i know your feelings, compatibility is s*cks 😆 😅 |
As shown in this old tweet https://twitter.com/taylorotwell/status/1355188002818035713, taylor otwell introducing
Str::markdown
use within laravel. This PR change markdown renderer from Maillable to Str class helper.The helper was introduced here laravel/framework#36171 and released here https://github.com/laravel/framework/releases/tag/v8.26.0.