Skip to content

Fix react 16 compatibility issue #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix react 16 compatibility issue #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions example/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var render = require('react-dom').render;
var moment = require('moment');
var createReactClass = require('create-react-class');

var D = React.DOM;
var D = React.createElement;

var TransitiveNumber = require('..');
var transitiveNumber = React.createFactory(TransitiveNumber);
Expand Down Expand Up @@ -37,57 +37,57 @@ var App = createReactClass({
});
},
render: function() {
return D.div(
return D('div',
null,
D.div(
D('div',
{ className: 'comparison' },
D.div(
D('div',
{ className: 'comparison__cell comparison__cell_head' },
'Plain HTML'
),
D.div(
D('div',
{ className: 'comparison__cell comparison__cell_head' },
'With ',
D.code(null, 'TransitiveNumber')
D('code', null, 'TransitiveNumber')
),
D.div(
D('div',
{ className: 'comparison__cell comparison__cell_first' },
D.div(
D('div',
{ className: 'timer' },
D.span({ className: 'timer__dot' }),
D.span(
D('span', { className: 'timer__dot' }),
D('span',
null,
moment(this.state.time * 1000).format('HH:mm:ss')
)
)
),
D.div(
D('div',
{ className: 'comparison__cell' },
D.div(
D('div',
{ className: 'timer' },
D.span({ className: 'timer__dot' }),
D('span', { className: 'timer__dot' }),
transitiveNumber(
null,
moment(this.state.time * 1000).format('HH:mm:ss')
)
)
),
D.div(
D('div',
{ className: 'comparison__cell comparison__cell_first' },
D.div(
D('div',
{ className: 'counter' },
D.button(
D('button',
{
className: 'counter__button counter__button_down',
type: 'button',
onClick: this.decrementCount
}
),
D.span(
D('span',
null,
this.state.count + ' points'
),
D.button(
D('button',
{
className: 'counter__button counter__button_up',
type: 'button',
Expand All @@ -96,11 +96,11 @@ var App = createReactClass({
)
)
),
D.div(
D('div',
{ className: 'comparison__cell' },
D.div(
D('div',
{ className: 'counter' },
D.button(
D('button',
{
className: 'counter__button counter__button_down',
type: 'button',
Expand All @@ -112,7 +112,7 @@ var App = createReactClass({
this.state.count
),
' points',
D.button(
D('button',
{
className: 'counter__button counter__button_up',
type: 'button',
Expand Down
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var React = require('react');
var D = React.DOM;
var D = React.createElement;
var createReactClass = require('create-react-class');

var Symbol = require('./symbol');
Expand All @@ -18,7 +18,7 @@ var TransitiveNumber = createReactClass({
// Invert animation direction when negative number is supplied.
var inverted = value[0] === '-';

return D.span(
return D('span',
{
className: this.props.className,
style: {
Expand Down
6 changes: 3 additions & 3 deletions symbol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var React = require('react');
var D = React.DOM;
var D = React.createElement;
var findDOMNode = require('react-dom').findDOMNode
var createReactClass = require('create-react-class');

Expand Down Expand Up @@ -47,7 +47,7 @@ var Symbol = createReactClass({
});
},
render: function() {
return D.span(
return D('span',
{
style: {
position: 'relative',
Expand All @@ -63,7 +63,7 @@ var Symbol = createReactClass({
);
},
renderSpacer: function() {
return D.span(
return D('span',
{
style: {
visibility: 'hidden'
Expand Down
4 changes: 2 additions & 2 deletions transition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var React = require('react');
var D = React.DOM;
var D = React.createElement;
var findDOMNode = require('react-dom').findDOMNode
var createReactClass = require('create-react-class');

Expand Down Expand Up @@ -69,7 +69,7 @@ var Transition = createReactClass({
return this.props.out || !this.state.in;
},
render: function() {
return D.span(
return D('span',
{
style: this.getAppearance()
},
Expand Down