Updated mutable Walkmesh format #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The walkmesh format is now correct and fully mutable.
Only previously public properties that have changed are Faces and and Verts, Which are no longer readonly.
Additional publicly facing members have been added. Some clean-up may still need to happen for documentation and correct property separation. Though hopefully this should just be plug and play for projects dependent on this class.
One things to note, reading in walk meshes for Dune Sea modules is oddly slow compared to the other meshes. Part of this is file size, but it doesn't seem to be a very linear growth. Some optimization may need to be done.
So we might want to consider adding a method for getting a lighter weight version (i.e. Verts, Faces, and materials only). This version would have to be immutable though.