Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lnd 377 refactor rpc tests divide by logic groups #23

Closed
wants to merge 30 commits into from
Closed

Lnd 377 refactor rpc tests divide by logic groups #23

wants to merge 30 commits into from

Conversation

ivansukach
Copy link
Collaborator

No description provided.

@ivansukach ivansukach force-pushed the LND-377-refactor-rpc-tests-divide-by-logic-groups branch 3 times, most recently from 7afa825 to 840f430 Compare May 16, 2024 14:01
@ivansukach ivansukach force-pushed the LND-377-refactor-rpc-tests-divide-by-logic-groups branch from c232a31 to 506e827 Compare May 31, 2024 08:51
@vasylNaumenko
Copy link
Collaborator

LGTM after fix (comment it) unused code
Error: vm/rpc_test.go:169:6: func testConsensusState is unused (U1000)
Error: vm/rpc_test.go:240:6: func testBlockResults is unused (U1000)

@ivansukach ivansukach marked this pull request as ready for review June 19, 2024 08:27
@ivansukach ivansukach closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivansukach @vasylNaumenko