Skip to content

[lua] Implement BST Ability "Killer Instinct"#7718

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
UmeboshiXI:BST_Ability_Killer_Instinct
Jul 22, 2025
Merged

[lua] Implement BST Ability "Killer Instinct"#7718
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
UmeboshiXI:BST_Ability_Killer_Instinct

Conversation

@UmeboshiXI
Copy link
Contributor

@UmeboshiXI UmeboshiXI commented Jul 17, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements missing BST Merit ability "Killer Instinct"
https://www.bg-wiki.com/ffxi/Killer_Instinct
https://ffxiclopedia.fandom.com/wiki/Killer_Instinct

Killer Instinct is similar to other job circle abilities. It applies to nearby party members and grants killer effects to them.

For this ability, the killer effect granted depends on the ability caster's current pet(See monster correlation)
https://ffxiclopedia.fandom.com/wiki/Beast_Strength_Chart

If the player has no pet out, the ability can not be used.

If a pet is despawned or killed, the effect does not wear off.

Steps to test these changes

  1. !additem fish_broth
  2. !getmod amorph_killer on self.
  3. Use Killer Instinct
  4. !getmod amorph_killer on self. See increase of mod.
  5. Test other pets for other mods and see they grant the corresponding killer mods.
    5a. Test on a party member, see party member also gain mods.
image

@UmeboshiXI UmeboshiXI force-pushed the BST_Ability_Killer_Instinct branch 2 times, most recently from 5ad3e93 to 3c6f68e Compare July 17, 2025 20:19
@wccbuck
Copy link
Contributor

wccbuck commented Jul 18, 2025

Cool, this can also be expanded upon eventually in conjunction with this PR #7477

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good. Do make the changes Sruon proposed, please.

@UmeboshiXI UmeboshiXI force-pushed the BST_Ability_Killer_Instinct branch from 3c6f68e to 4974216 Compare July 19, 2025 04:01
@Xaver-DaRed Xaver-DaRed merged commit 999aee8 into LandSandBoat:base Jul 22, 2025
24 of 25 checks passed
claybie pushed a commit to claybie/LeafSpringCog that referenced this pull request Aug 11, 2025
…er_Instinct

[lua] Implement BST Ability "Killer Instinct"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants