Skip to content

Conversation

@Lamparter
Copy link
Owner

Resolved / Related Issues


Adds a CI workflow to CubeKit

@Lamparter Lamparter linked an issue Jan 25, 2025 that may be closed by this pull request
@Lamparter Lamparter marked this pull request as draft January 26, 2025 08:16
@Lamparter Lamparter self-assigned this Jan 26, 2025
@Lamparter Lamparter added this to the Refresh Toolkit milestone Jan 26, 2025
@Lamparter Lamparter force-pushed the lamparter/ci-cd branch 2 times, most recently from 4a9dc72 to 71db91e Compare January 26, 2025 09:33
@Lamparter

This comment was marked as outdated.

@Lamparter
Copy link
Owner Author

CI works!
The builds are failing because Riverside.Extensions.Accountability hasn't actually been published yet (so on Release mode they fail)

@Lamparter
Copy link
Owner Author

The main thing is the CD: it should be similar to the Files UI controls CD

  • Detect if CurrentVersion.props was changed in a commit/PR
  • Publish

Problem with this is that there is an ORDER that the packages must be published in, and it will take time for each package to be reviewed by the Nuget server.

@Lamparter Lamparter marked this pull request as ready for review March 9, 2025 12:29
@Lamparter Lamparter requested a review from Copilot March 9, 2025 12:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds CI and CD workflows to CubeKit to automate the build, test, and deployment processes.

  • Introduces a CD workflow that builds, packages, and publishes CubeKit to NuGet.
  • Introduces a CI workflow that validates formatting (with XAML Styler) and builds multiple project configurations and targets.

Reviewed Changes

File Description
.github/workflows/cd.yml Adds a CD workflow for building, packing, and publishing CubeKit
.github/workflows/ci.yml Adds a CI workflow for formatting checks and multi-configuration builds

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Lamparter and others added 2 commits March 9, 2025 13:53
Thanks to Arlo for mentioning this!
Co-authored-by: Arlo <9384894+Arlodotexe@users.noreply.github.com>
@Lamparter
Copy link
Owner Author

Lamparter commented Mar 9, 2025

Everything works and is finished
Let's just wait for the final CI run and then after it all passes it's merge time!

@Lamparter Lamparter merged commit 2c6bb0f into main Mar 9, 2025
79 checks passed
@Lamparter Lamparter deleted the lamparter/ci-cd branch March 9, 2025 17:29
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in CubeKit Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub: Add CI

2 participants