Skip to content

Commit

Permalink
Configure/Makefile: fix the -macopt argument of the fipsinstall com…
Browse files Browse the repository at this point in the history
…mand

The FIPS hmac key is provided as a hexadezimal string, which needs to
be be prefixed with `hexkey:`, not `key:`.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#13684)
  • Loading branch information
mspncp committed Apr 29, 2021
1 parent f4585ae commit 59cf286
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Configurations/descrip.mms.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ install_fips: install_sw
openssl fipsinstall -
-module ossl_installroot:[MODULES{- $sover_dirname.$target{pointer_size} -}.'arch']$(FIPSMODULENAME) -
-out ossl_installroot:[MODULES{- $sover_dirname.$target{pointer_size} -}.'arch']$(FIPSMODULENAME).cnf -
-macopt "key:$(FIPSKEY)"
-macopt "hexkey:$(FIPSKEY)"

uninstall_fips: uninstall_sw
@ WRITE SYS$OUTPUT "*** Uninstalling FIPS module configuration"
Expand Down
2 changes: 1 addition & 1 deletion Configurations/unix-Makefile.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ install_fips: install_sw
@$(ECHO) "fipsinstall $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME).cnf"
@openssl fipsinstall -module $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME) \
-out $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME).cnf \
-macopt 'key:$(FIPSKEY)'
-macopt 'hexkey:$(FIPSKEY)'

uninstall_fips: uninstall_sw
@$(ECHO) "*** Uninstalling FIPS module configuration"
Expand Down
2 changes: 1 addition & 1 deletion Configurations/windows-makefile.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ install_fips: install_sw
@$(ECHO) "fipsinstall $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME).cnf"
@openssl fipsinstall -module $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME) \
-out $(DESTDIR)$(MODULESDIR)/$(FIPSMODULENAME).cnf \
-macopt "key:$(FIPSKEY)"
-macopt "hexkey:$(FIPSKEY)"

uninstall_fips: uninstall_sw
@$(ECHO) "*** Uninstalling FIPS module configuration"
Expand Down

0 comments on commit 59cf286

Please sign in to comment.