Skip to content

Conversation

@Lakitna
Copy link
Owner

@Lakitna Lakitna commented Sep 4, 2021

Closes #60

  • Tests
  • Documentation
  • Type definitions
  • Ready for merge

@Lakitna
Copy link
Owner Author

Lakitna commented Sep 4, 2021

Will also close #54

@cubanx
Copy link

cubanx commented Sep 8, 2021

Sorry, not trying to harass, but can I help with this in any way? We want to move up to version 8.3+ of Cypress so we can get access to session stuff, but currently blocked.

If you don't think you can get to it within a week or so, I can do a fork of your code and work off that in the meantime.

Thanks so much for everything!

@Lakitna
Copy link
Owner Author

Lakitna commented Sep 13, 2021

I had a week off last week, hence the delay. Merge is pending (self-) review right now.

I want to release this as part of cypress-commands@2 (milestone https://github.com/Lakitna/cypress-commands/milestone/3) which will also include a breaking change for the order of text() (see #47)

@Lakitna
Copy link
Owner Author

Lakitna commented Sep 13, 2021

@cubanx I just added the changelog with the breaking changes to this branch. You can start looking at potential changes you have to make ;)

I plan to take a last look at things tomorrow before I release it.

@cubanx
Copy link

cubanx commented Sep 14, 2021

Thanks so much! Really appreciate the work here, and if there's ever something you want me to work on let me know. I am not a super expert here, but I've been around the block a few times :)

@Lakitna Lakitna merged commit c1d0cf9 into develop Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute Command not working

3 participants