Skip to content

[Core] Add exception handling to BaseService Parse method and SocketContext OnSocketError #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Core] Add exception handling to BaseService Parse method and SocketContext OnSocketError #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f46c8
Initial plan
Copilot Aug 25, 2025
c6841cd
Add exception handling to BaseService Parse method and SocketContext …
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lagrange.Core/Internal/Context/SocketContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void OnDisconnect()

public void OnSocketError(Exception e, ReadOnlyMemory<byte> data)
{

_context.LogError(Tag, "Socket error occurred during packet processing: {0}", e, e.Message);
}

public async Task<bool> Connect()
Expand Down
15 changes: 14 additions & 1 deletion Lagrange.Core/Internal/Services/BaseService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,24 @@ namespace Lagrange.Core.Internal.Services;

internal abstract class BaseService<TReq, TResp> : IService where TReq : ProtocolEvent where TResp : ProtocolEvent
{
private const string Tag = nameof(BaseService);

protected virtual ValueTask<TResp> Parse(ReadOnlyMemory<byte> input, BotContext context) => ValueTask.FromResult<TResp>(null!);

protected virtual ValueTask<ReadOnlyMemory<byte>> Build(TReq input, BotContext context) => ValueTask.FromResult(ReadOnlyMemory<byte>.Empty);

async ValueTask<ProtocolEvent> IService.Parse(ReadOnlyMemory<byte> input, BotContext context) => await Parse(input, context);
async ValueTask<ProtocolEvent> IService.Parse(ReadOnlyMemory<byte> input, BotContext context)
{
try
{
return await Parse(input, context);
}
catch (Exception e)
{
context.LogError(Tag, "Parse method failed for service {0}", e, GetType().Name);
throw;
}
}

ValueTask<ReadOnlyMemory<byte>> IService.Build(ProtocolEvent input, BotContext context) => Build((TReq)input, context);
}