-
Notifications
You must be signed in to change notification settings - Fork 14
Implement parquet backed storage #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
37aa385 to
783341f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- parquet_{node,rel}_table.{cpp,h} - these four files have the bulk of the implementation.
| ScanTable::initLocalStateInternal(resultSet, context); | ||
| auto nodeIDVector = resultSet->getValueVector(opInfo.nodeIDPos).get(); | ||
| scanState = std::make_unique<NodeTableScanState>(nodeIDVector, outVectors, nodeIDVector->state); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the parquet implementation hooks into the query pipeline for node tables.
| auto nbrNodeIDVector = outVectors[0]; | ||
| scanState = std::make_unique<RelTableScanState>(*MemoryManager::Get(*clientContext), | ||
| boundNodeIDVector, outVectors, nbrNodeIDVector->state); | ||
| // Check if this is a ParquetRelTable and create appropriate scan state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the parquet implementation hooks into the query pipeline for rel tables.
|
Nice one! |
783341f to
0ec9255
Compare
|
@Vasilije1990 sorry I missed your comment. How's your s3 loader different from kuzu/ladybug's |
0ec9255 to
9af680b
Compare
9af680b to
a82271f
Compare
More context in this blog post