LibCore: Remove the dummy EventReceiver from deferred_invoke() #6993
+24
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaggy1024
force-pushed
the
deferred-invoke-race-condition
branch
2 times, most recently
from
f9bb2b0 to
32e969b
Compare
Zaggy1024
changed the title
Zaggy1024
force-pushed
the
deferred-invoke-race-condition
branch
from
32e969b to
44d40fa
Compare
Contributor
|
Could this get tested against the Windows CI as well? |
Zaggy1024
force-pushed
the
deferred-invoke-race-condition
branch
from
44d40fa to
3202553
Compare
Contributor
Author
|
Ah, good point, I'll add the windows label. |
Zaggy1024
added
the
windows
Zaggy1024
force-pushed
the
deferred-invoke-race-condition
branch
from
3202553 to
8088588
Compare
The DeferredInvocationContext only existed to satisfy the requirement in ThreadEventQueue that each event has an EventReceiver. However, deferred_invoke() was not even using the EventReceiver to call its callback. Therefore, we don't need to allocate one for every deferred invocation. This also prevents WeakPtr::strong_ref() from racing and leaking the context object when invoking a function across threads.
Zaggy1024
force-pushed
the
deferred-invoke-race-condition
branch
from
8088588 to
f5e61b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeferredInvocationContext only existed to satisfy the requirement in ThreadEventQueue that each event has an EventReceiver. However, deferred_invoke() was not even using the EventReceiver to call its callback. Therefore, we don't need to allocate one for every deferred invocation.
This also prevents WeakPtr::strong_ref() from racing and leaking the context object when invoking a function across threads.