Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Correctly implement event listeners default passive attribute #3035

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

skyz1
Copy link
Contributor

@skyz1 skyz1 commented Dec 24, 2024

This PR implements the default value of the passive attribute of event listeners according to the spec.

This makes this WPT test pass.

Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion.

Libraries/LibWeb/DOM/EventTarget.cpp Outdated Show resolved Hide resolved
This commit implements the default value of the passive attribute of
event listeners according to the spec.
@skyz1 skyz1 force-pushed the events-passive-default branch from 1cda49d to 7cafc41 Compare December 25, 2024 13:42
@tcl3 tcl3 enabled auto-merge (rebase) December 25, 2024 14:44
@tcl3 tcl3 merged commit 0858974 into LadybirdBrowser:master Dec 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants