Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/CSS+Animations+DOM: Add support for TransitionEvents #3024

Merged
merged 6 commits into from
Dec 25, 2024
Merged

LibWeb/CSS+Animations+DOM: Add support for TransitionEvents #3024

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbe4a48
LibWeb/CSS: Add the TransitionEvent type
LucasChollet Dec 22, 2024
4ee4129
LibWeb/Animations: Don't try to associate animations to null timelines
LucasChollet Dec 23, 2024
2d19b4b
LibWeb/Animations: Consider CSSTransitions in `is_replaceable()`
LucasChollet Dec 23, 2024
44c3e39
LibWeb/Animations: Don't assume that animations have an effect
LucasChollet Dec 23, 2024
5fe4a48
LibWeb/CSS: Don't assume that animations have an associated effect
LucasChollet Dec 23, 2024
1add5a3
LibWeb/DOM: Fire transition[cancel,start,run,end] events
LucasChollet Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LibWeb/CSS: Don't assume that animations have an associated effect 
... when computing properties.
  • Loading branch information
@LucasChollet
LucasChollet committed Dec 23, 2024
commit 5fe4a4828364e188ba23febd1d11551f77992e33
6 changes: 5 additions & 1 deletion Libraries/LibWeb/CSS/StyleComputer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,9 @@ void StyleComputer::collect_animation_into(DOM::Element& element, Optional<CSS::

static void apply_animation_properties(DOM::Document& document, CascadedProperties& cascaded_properties, Animations::Animation& animation)
{
if (!animation.effect())
return;

auto& effect = verify_cast<Animations::KeyframeEffect>(*animation.effect());

Optional<CSS::Time> duration;
Expand Down Expand Up @@ -2401,7 +2404,8 @@ GC::Ref<ComputedProperties> StyleComputer::compute_properties(DOM::Element& elem
animation->play().release_value_but_fixme_should_propagate_errors();
} else {
// The animation hasn't changed, but some properties of the animation may have
apply_animation_properties(m_document, cascaded_properties, *element.cached_animation_name_animation(pseudo_element));
if (auto animation = element.cached_animation_name_animation(pseudo_element); animation)
apply_animation_properties(m_document, cascaded_properties, *animation);
}
}
} else {
Expand Down