Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/Geometry: Implement "other than none" keyword check in DOMMatrix init #3008

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

tannerdrake-dev
Copy link
Contributor

This implementation leads to passing more WPT tests. Relevant test imported in this PR.

@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@tannerdrake-dev tannerdrake-dev force-pushed the wpt-fixes branch 7 times, most recently from a36b224 to 94e1f68 Compare December 22, 2024 16:26
@tannerdrake-dev tannerdrake-dev changed the title LibWeb/Geometry: Implement "other than none" keyword check in DOMMatrix init. LibWeb/Geometry: Implement "other than none" keyword check in DOMMatrix init Dec 22, 2024
@tcl3
Copy link
Member

tcl3 commented Dec 26, 2024

Hi, thanks for working on this! The change itself looks OK to me, but we try to avoid adding commits that modify work done in previous commits. All the changes made in this PR should be squashed into the first commit, then I think this should be good to go. Feel free to ask on Discord if you need help with this.

@tannerdrake-dev tannerdrake-dev force-pushed the wpt-fixes branch 2 times, most recently from d3bf9c9 to cb9a026 Compare December 26, 2024 21:32
@tannerdrake-dev
Copy link
Contributor Author

Hi, thanks for working on this! The change itself looks OK to me, but we try to avoid adding commits that modify work done in previous commits. All the changes made in this PR should be squashed into the first commit, then I think this should be good to go. Feel free to ask on Discord if you need help with this.

Thanks for the review. I have squashed the commits down to one as requested.

@gmta
Copy link
Collaborator

gmta commented Dec 28, 2024

Your commit message is now an amalgamation of the individual commit titles that existed before the squash. You should write a proper commit message instead.

@tannerdrake-dev
Copy link
Contributor Author

Your commit message is now an amalgamation of the individual commit titles that existed before the squash. You should write a proper commit message instead.

Commit message has been updated to just the proper original message.

@gmta gmta enabled auto-merge (rebase) December 28, 2024 06:24
@gmta gmta merged commit fe25f77 into LadybirdBrowser:master Dec 28, 2024
8 checks passed
@tannerdrake-dev tannerdrake-dev deleted the wpt-fixes branch December 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants