Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibCore: Port SystemServerTakeover.cpp to Windows #2910

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stasoid
Copy link
Contributor

@stasoid stasoid commented Dec 14, 2024

Requires #2946 (fails to compile on Linux w/o it)

@circl-lastname
Copy link
Contributor

circl-lastname commented Dec 14, 2024

This isn't an issue with the PR, but the name take_over_socket_from_system_server definitely isn't accurate anymore since SerenityOS's SystemServer is a concept which doesn't apply to Windows or Linux.

I found that SOCKET_TAKEOVER is actually set by LibWebView when the UI process spawns WebContent

TRY(Core::Environment::set("SOCKET_TAKEOVER"sv, takeover_string, Core::Environment::Overwrite::Yes));

@stasoid stasoid marked this pull request as ready for review December 17, 2024 11:11
@stasoid stasoid marked this pull request as draft December 26, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants