Build: Require fontconfig on macos #2723
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
gigamonster256
force-pushed
the
master
branch
from
0f59385 to
6ef3eb8
Compare
gigamonster256
changed the title
gigamonster256
force-pushed
the
master
branch
from
6ef3eb8 to
6e8cb21
Compare
gigamonster256
commented
Dec 7, 2024
| @@ -5,7 +5,7 @@ include(fontconfig) | |||
| find_package(unofficial-skia CONFIG) | |||
| if(unofficial-skia_FOUND) | |||
| set(SKIA_TARGET unofficial::skia::skia) | |||
| if (HAS_FONTCONFIG) | |||
| if (HAS_FONTCONFIG AND NOT APPLE) | |||
There was a problem hiding this comment.
OSX linker doesn't support --no-as-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on getting the nix version of ladybird working on macos and noticed that as of dd1b8de, fontconfig is required on macos but the fontconfig cmake file was not updated.