Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable GNU toolchain #2709

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kalenikaliaksandr
Copy link
Member

Motivation:

  • Sooner or later we will start using Swift supported only by Clang
  • GCC CI runs tests visibly slower than Clang CI
  • Less build issues with Clang, e.g. recent attempt to add ANGLE that fails to compile with GCC

Motivation:
- Sooner or later we will start using Swift supported only by Clang
- GCC CI runs tests visibly slower than Clang CI
- Less build issues with Clang, e.g. recent attempt to add ANGLE that
  fails to compile with GCC
@awesomekling
Copy link
Member

This makes sense to me. The GCC CI is a constant source of annoyances and time-wasting, unfortunately.

@LucasChollet
Copy link
Contributor

LucasChollet commented Dec 2, 2024

If we go down this way, we probably also want to reject GCC in ladybird.sh. People will try to build with GCC and it will result in errors the second you remove the build from CI.

@rmg-x
Copy link
Contributor

rmg-x commented Dec 2, 2024

Same with documentation updates to avoid an uptick in issues and/or people going to #build-problems on Discord 😅

@shlyakpavel
Copy link
Contributor

Do I understand correctly that once we make Swift mandatory, we’ll be committed to using a single toolchain for a long time?

@kalenikaliaksandr kalenikaliaksandr marked this pull request as draft December 2, 2024 19:04
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants