Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Add documentation to the date parser format #2681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LibWeb: Add documentation to the date parser format #2681

wants to merge 1 commit into from
+28 −0

Conversation

Arhcout
Copy link
Contributor

@Arhcout Arhcout commented Dec 1, 2024

So we don't have to dig in the parser's code

AtkinsSJ
AtkinsSJ requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These same format codes are used in DateTime::to_string() as well. Can they be moved somewhere clearer, maybe into the DateTime header?

Libraries/LibCore/DateTime.cpp Outdated
// %x: require single number to represent hour and minutes
// %X: require sub second precision
// %Z: require timezone name
// %+: ignore untile next '%'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "untile"

@Arhcout
LibWeb: Add documentation to the date parser format
e486e3b 
So we don't have to dig in the parser's code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtkinsSJ AtkinsSJ AtkinsSJ requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arhcout @AtkinsSJ