-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibIPC: Port to Windows #2643
base: master
Are you sure you want to change the base?
LibIPC: Port to Windows #2643
Conversation
d46eb67
to
5f6ecf9
Compare
365b491
to
f9b95b6
Compare
4f57a24
to
70a8093
Compare
30713c0
to
89d6a38
Compare
@@ -27,54 +27,45 @@ namespace IPC::Concepts { | |||
|
|||
namespace Detail { | |||
|
|||
// Cannot use SpecializationOf with these templates because they have non-type parameters. See https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1985r3.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the order of declarations, which makes the diff unreadable. This is a diff that shows changes of substance (without reordering or inline
removing).
@R-Goc @konradekk Please don't comment on my PRs. I am only interested in reviews from maintainers. So far your comments provided very little value for me. I thought I can just ignore your comments, but Jelle Raaijmakers says unresolved comments may be the reason why my PR is not getting a review from maintainers, so I am asking not to spam here. I am marking all conversations as resolved now to increase my chances for a review from maintainers. |
I found a problem with the handling of sockets. When given a socket fd, _close does not call closesocket, it calls CloseHandle. But the doc for CloseHandle specifically says that CloseHandle should not be used for sockets. So WIN32 APIs behave inconsistently here. If _close cannot properly handle socket fds why _open_osfhandle works for socket handles? It should fail as it does for file mapping handles. This cannot be fixed just by adding So I am marking this as draft for now. |
To fix the problem above, I now treat socket handles the same as file mapping handles. I.e. using pseudo file descriptor instead of calling _open_osfhandle, see #2946. |
615c9a8
to
c3a5079
Compare
Requires #2673 #2674 #2946