Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some oddities browsing Lemmy.ml #350

Open
Daeraxa opened this issue Jul 2, 2024 · 4 comments
Open

Some oddities browsing Lemmy.ml #350

Daeraxa opened this issue Jul 2, 2024 · 4 comments
Labels
bug Something isn't working web compatibility

Comments

@Daeraxa
Copy link
Contributor

Daeraxa commented Jul 2, 2024 •
edited
Loading

Just built Ladybird from bce7b24 and noticed a few oddities rendering the front page on Lemmy.ml. Comparison using FF 127.0.2. Apologies if these are known issues but couldn't seem to find anything, at least for the first one.

Issues on switcher:

Ladybird - dot showing in upper left and missing bottom border:
image

FF
image

Missing SVG icons (suspect this is the same as #141 as it also has a <use xlink:href> )

Ladybird
image

FF
image
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Jul 27, 2024
@shannonbooth
SVG: Add support for fetching SVG use elements from external documents
ed47f27 
This allows SVG <use> elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or Lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Jul 27, 2024
@shannonbooth
SVG: Add support for fetching SVG use elements from external documents
1fa70a7 
This allows SVG <use> elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or Lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Jul 27, 2024
@shannonbooth
SVG: Add support for fetching SVG use elements from external documents
cc698f9 
This allows SVG <use> elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or Lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Jul 27, 2024
@shannonbooth
SVG: Add support for fetching SVG use elements from external documents
71f3dfe 
This allows SVG <use> elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or Lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
@shannonbooth shannonbooth mentioned this issue Jul 27, 2024
Merged
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Jul 27, 2024
@shannonbooth
SVG: Add support for fetching SVG use elements from external documents
01ebbb3 
This allows SVG <use> elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or Lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Aug 3, 2024
@shannonbooth
LibWeb: Add support for fetching SVG use elements from external docs
e14be0f 
This allows SVG elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or on lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Aug 3, 2024
@shannonbooth
LibWeb: Add support for fetching SVG use elements from external docs
60df637 
This allows SVG elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or on lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
shannonbooth added a commit to shannonbooth/ladybird that referenced this issue Aug 4, 2024
@shannonbooth
LibWeb: Add support for fetching SVG use elements from external docs
e6c7322 
This allows SVG elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or on lemmy.ml

Fixes: LadybirdBrowser#141
Progress towards: LadybirdBrowser#350
awesomekling pushed a commit that referenced this issue Aug 5, 2024
@shannonbooth @awesomekling
LibWeb: Add support for fetching SVG use elements from external docs
85e8e7e 
This allows SVG elements to refer to elements which are in other
documents, such as https://www.neogaf.com/forums/gaming-discussion.2/
or on lemmy.ml

Fixes: #141
Progress towards: #350
@AtkinsSJ
Copy link
Member

AtkinsSJ commented Sep 9, 2024

Current status: dot is still there, but the other mentioned issues are fixed.
image

@AtkinsSJ AtkinsSJ added bug Something isn't working web compatibility labels Sep 9, 2024
@shlyakpavel
Copy link
Contributor

shlyakpavel commented Nov 3, 2024 •
edited
Loading

Current status: it crashes as of 0db171c

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BREAKPOINT (code=1, subcode=0x10161e2f4)
  * frame #0: 0x000000010161e2f4 liblagom-ak.0.0.0.dylib`::ak_verification_failed() at Assertions.cpp:102:5 [opt]
    frame #1: 0x00000001035f3818 liblagom-web.0.0.0.dylib`::static_position() [inlined] value at Optional.h:314:9 [opt]
    frame #2: 0x00000001035f380c liblagom-web.0.0.0.dylib`::static_position() [inlined] operator-> at Optional.h:137:89 [opt]
    frame #3: 0x00000001035f380c liblagom-web.0.0.0.dylib`::static_position() at LayoutState.h:180:20 [opt]
    frame #4: 0x00000001035f2d90 liblagom-web.0.0.0.dylib`::operator()() at FormattingContext.cpp:785:53 [opt]
    frame #5: 0x00000001035eea3c liblagom-web.0.0.0.dylib`::compute_width_for_absolutely_positioned_non_replaced_element() at FormattingContext.cpp:818:23 [opt]
    frame #6: 0x00000001035ed9d4 liblagom-web.0.0.0.dylib`::compute_width_for_absolutely_positioned_element() at FormattingContext.cpp:542:9 [opt]
    frame #7: 0x00000001035f4104 liblagom-web.0.0.0.dylib`::layout_absolutely_positioned_element() at FormattingContext.cpp:1211:5 [opt]
    frame #8: 0x00000001035e3bf8 liblagom-web.0.0.0.dylib`::parent_context_did_dimension_child_root_box() at FlexFormattingContext.cpp:199:9 [opt]
    frame #9: 0x00000001035dbd2c liblagom-web.0.0.0.dylib`::layout_block_level_box() at BlockFormattingContext.cpp:806:41 [opt]
    frame #10: 0x00000001035d559c liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] operator() at BlockFormattingContext.cpp:817:9 [opt]
    frame #11: 0x00000001035d5584 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:239:21 [opt]
    frame #12: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:248:54 [opt]
    frame #13: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() at BlockFormattingContext.cpp:816:21 [opt]
    frame #14: 0x00000001035d4dcc liblagom-web.0.0.0.dylib`::run() at BlockFormattingContext.cpp:79:9 [opt]
    frame #15: 0x00000001035dfc48 liblagom-web.0.0.0.dylib`::run() at FlexFormattingContext.cpp:174:55 [opt]
    frame #16: 0x00000001035db8c8 liblagom-web.0.0.0.dylib`::layout_block_level_box() at BlockFormattingContext.cpp:757:41 [opt]
    frame #17: 0x00000001035d559c liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] operator() at BlockFormattingContext.cpp:817:9 [opt]
    frame #18: 0x00000001035d5584 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:239:21 [opt]
    frame #19: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:248:54 [opt]
    frame #20: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() at BlockFormattingContext.cpp:816:21 [opt]
    frame #21: 0x00000001035db9a4 liblagom-web.0.0.0.dylib`::layout_block_level_box() at BlockFormattingContext.cpp:775:13 [opt]
    frame #22: 0x00000001035d559c liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] operator() at BlockFormattingContext.cpp:817:9 [opt]
    frame #23: 0x00000001035d5584 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:239:21 [opt]
    frame #24: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:248:54 [opt]
    frame #25: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() at BlockFormattingContext.cpp:816:21 [opt]
    frame #26: 0x00000001035db9a4 liblagom-web.0.0.0.dylib`::layout_block_level_box() at BlockFormattingContext.cpp:775:13 [opt]
    frame #27: 0x00000001035d559c liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] operator() at BlockFormattingContext.cpp:817:9 [opt]
    frame #28: 0x00000001035d5584 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:239:21 [opt]
    frame #29: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:248:54 [opt]
    frame #30: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() at BlockFormattingContext.cpp:816:21 [opt]
    frame #31: 0x00000001035d4dcc liblagom-web.0.0.0.dylib`::run() at BlockFormattingContext.cpp:79:9 [opt]
    frame #32: 0x00000001035db8c8 liblagom-web.0.0.0.dylib`::layout_block_level_box() at BlockFormattingContext.cpp:757:41 [opt]
    frame #33: 0x00000001035d559c liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] operator() at BlockFormattingContext.cpp:817:9 [opt]
    frame #34: 0x00000001035d5584 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:239:21 [opt]
    frame #35: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() [inlined] for_each_child_of_type<Web::Layout::Box, (lambda at /Users/pavel/Develop/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:816:49)> at TreeNode.h:248:54 [opt]
    frame #36: 0x00000001035d5554 liblagom-web.0.0.0.dylib`::layout_block_level_children() at BlockFormattingContext.cpp:816:21 [opt]
    frame #37: 0x00000001033a8ba0 liblagom-web.0.0.0.dylib`::update_layout() at Document.cpp:1213:33 [opt]
    frame #38: 0x000000010349dcc4 liblagom-web.0.0.0.dylib`::update_the_rendering() at EventLoop.cpp:338:23 [opt]
    frame #39: 0x00000001032206a0 liblagom-web.0.0.0.dylib`::operator()() at Function.h:120:25 [opt]
    frame #40: 0x000000010349d490 liblagom-web.0.0.0.dylib`::process() at EventLoop.cpp:177:22 [opt]
    frame #41: 0x00000001032206a0 liblagom-web.0.0.0.dylib`::operator()() at Function.h:120:25 [opt]
    frame #42: 0x000000010123a708 liblagom-core.0.0.0.dylib`::operator()() at Function.h:120:25 [opt]
    frame #43: 0x000000010123f7d0 liblagom-core.0.0.0.dylib`::dispatch_event() at EventReceiver.cpp:162:17 [opt]
    frame #44: 0x000000010124e2bc liblagom-core.0.0.0.dylib`::process() at ThreadEventQueue.cpp:121:23 [opt]
    frame #45: 0x000000010123962c liblagom-core.0.0.0.dylib`::exec() [inlined] pump at EventLoopImplementationUnix.cpp:324:40 [opt]
    frame #46: 0x0000000101239618 liblagom-core.0.0.0.dylib`::exec() at EventLoopImplementationUnix.cpp:316:9 [opt]
    frame #47: 0x0000000101237e7c liblagom-core.0.0.0.dylib`::exec() at EventLoop.cpp:88:20 [opt]
    frame #48: 0x0000000100e892bc WebContent`::serenity_main() at main.cpp:208:23 [opt]
    frame #49: 0x0000000100f20784 WebContent`main at Main.cpp:39:19 [opt]
    frame #50: 0x0000000194090274 dyld`start + 2840

@tcl3
Copy link
Member

tcl3 commented Nov 3, 2024

Current status: it crashes as of 0db171c

I've bisected this crash to 863416e.

@shlyakpavel
Copy link
Contributor

The crash is still there as of f638f84. Can we maybe tag @kalenikaliaksandr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working web compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AtkinsSJ @tcl3 @shlyakpavel @Daeraxa