-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LibWeb: Don't insert out-of-flow elements into block pseudo elements
Like 1132c85, out-of-flow elements such as float elements would get inserted into block level `::before` and `::after` pseudo-element nodes when they should instead be inserted as a sibling to the pseudo element. This change fixes that. This fixes a few layout issues on the swedish tax agency website (skatteverket.se). :^)
- Loading branch information
1 parent
196922a
commit 9ed2669
Showing
3 changed files
with
29 additions
and
0 deletions.
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
.../LibWeb/Layout/expected/block-and-inline/out-of-flows-not-inserted-into-generated-box.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
Viewport <#document> at (0,0) content-size 800x600 children: not-inline | ||
BlockContainer <html> at (0,0) content-size 800x42 [BFC] children: not-inline | ||
BlockContainer <body> at (8,8) content-size 784x17 children: not-inline | ||
BlockContainer <(anonymous)> at (8,8) content-size 784x17 children: inline | ||
frag 0 from TextNode start: 0, length: 3, rect: [8,8 27.15625x17] baseline: 13.296875 | ||
"foo" | ||
TextNode <#text> | ||
BlockContainer <div> at (8,25) content-size 27.640625x17 floating [BFC] children: inline | ||
frag 0 from TextNode start: 0, length: 3, rect: [8,25 27.640625x17] baseline: 13.296875 | ||
"bar" | ||
TextNode <#text> | ||
|
||
ViewportPaintable (Viewport<#document>) [0,0 800x600] | ||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x42] | ||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x17] overflow: [8,8 784x34] | ||
PaintableWithLines (BlockContainer(anonymous)) [8,8 784x17] | ||
TextPaintable (TextNode<#text>) | ||
PaintableWithLines (BlockContainer<DIV>) [8,25 27.640625x17] | ||
TextPaintable (TextNode<#text>) |
9 changes: 9 additions & 0 deletions
9
Tests/LibWeb/Layout/input/block-and-inline/out-of-flows-not-inserted-into-generated-box.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<!DOCTYPE html><style> | ||
body::before { | ||
content: "foo"; | ||
display: block; | ||
} | ||
div { | ||
float: left; | ||
} | ||
</style><body><div>bar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters