Fix thread leak #16
Merged
Fix thread leak #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Creating a new executor each call to
AbstractTickSpotifyAPI#initializeeven if properly shutdown leads to high memory usage. While this memory would eventually be reclaimed by the JVM, it feels correct to avoid it if possible. As such I opted to create a single executor per instance ofAbstractTickSpotifyAPI. This necessitated the creation ofSpotifyAPI#shutdownto support occasions where the user of the library chooses to not use the built-in auto-reconnect functionality in favour of their own.