Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration support for python 3.13 #1940

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jan 10, 2025

Description

Story: https://labelbox.atlassian.net/browse/PLT-1578

Python 3.13 SDK Support Update
Initial Assessment

Python 3.13 primarily focuses on internal changes:

  • Free threading in Global Interpreter Lock (GIL)
  • JIT compiler implementation

Challenges Encountered

Package Compatibility Issues

Several dependencies failed to work with Python 3.13
Root cause: Changes to the GIL API

Platform-Specific Behavior

Docker/Linux: Rye correctly selected package versions
macOS: rye sync operation failed

Resolution

Identified rpds-py (Rust-Python interface) as the source of problems
Updating to the latest version of rpds-py resolved the issue
Successfully enabled correct package installation via Rye on macOS

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients January 10, 2025 23:06 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-example January 10, 2025 23:06 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients January 12, 2025 05:12 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-example January 12, 2025 05:12 — with GitHub Actions Inactive
@vbrodsky vbrodsky marked this pull request as ready for review January 13, 2025 18:14
@vbrodsky vbrodsky requested a review from a team as a code owner January 13, 2025 18:14
@@ -5,7 +5,7 @@ ENV LANG="C.UTF-8" \
LC_ALL="C.UTF-8" \
PATH="/home/python/.local/bin:/home/python/.rye/shims:$PATH" \
PIP_NO_CACHE_DIR="false" \
RYE_VERSION="0.36.0" \
RYE_VERSION="0.43.0" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 2 latest rye versions support 3.13

@vbrodsky vbrodsky merged commit abab039 into develop Jan 13, 2025
31 of 37 checks passed
@vbrodsky vbrodsky deleted the VB/add-p3.13_PLT-1578_2 branch January 13, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants