Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vb/member export plt 2099 #1925

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Vb/member export plt 2099 #1925

merged 3 commits into from
Dec 10, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Dec 10, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-2099

Adds export group members

NOTE: currently only emails are exported

NOTE: sdk integration test is not trivial, will build it as https://labelbox.atlassian.net/browse/PLT-2168

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner December 10, 2024 01:20
@vbrodsky vbrodsky force-pushed the VB/member-export_PLT-2099 branch from d75168d to a6738d7 Compare December 10, 2024 01:22
email: str


class UserGroupV2:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed UserMemberUpload

)
)

return members_list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@vbrodsky vbrodsky merged commit b6427ed into develop Dec 10, 2024
16 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/member-export_PLT-2099 branch December 10, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants