Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd NDSegments #1903

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Readd NDSegments #1903

merged 3 commits into from
Nov 15, 2024

Conversation

vbrodsky
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky changed the title Remove NDSegments Readd NDSegments Nov 14, 2024
@vbrodsky vbrodsky marked this pull request as ready for review November 14, 2024 22:48
@vbrodsky vbrodsky requested a review from a team as a code owner November 14, 2024 22:49
@vbrodsky vbrodsky merged commit 47539df into develop Nov 15, 2024
18 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/remove-dicomm-2_PLT-1853 branch November 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants