Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vb/prompt rating plt 1710 #1891

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Vb/prompt rating plt 1710 #1891

merged 12 commits into from
Nov 21, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 1, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1710

Prompt Issue ontology is an ontology tool with a canned checklist classification where someone can update checkboxes but not the classification itself

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@@ -0,0 +1,367 @@
import warnings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved these classes to a separate package to avoid circular dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@vbrodsky vbrodsky force-pushed the VB/prompt-rating_PLT-1710 branch from 832ef39 to bee3924 Compare November 21, 2024 19:47
@vbrodsky vbrodsky marked this pull request as ready for review November 21, 2024 19:51
@vbrodsky vbrodsky requested a review from a team as a code owner November 21, 2024 19:51
@vbrodsky vbrodsky merged commit a7e7532 into develop Nov 21, 2024
16 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/prompt-rating_PLT-1710 branch November 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants