new version 0.14.2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
choppsv1
commented
May 4, 2024
choppsv1
commented
- new version 0.14.2
- always fail mutest tests on bad json inputs
- improve ssh-remote for common use-case of connecting to host connected devices
- fix ready-cmd for python v3.11+
Previously only supported reaching nodes within the topology which was actually a very uncommon use case (but the one that we can easily test in CI). Now we support reaching the server using the host network namespace. It is far more likely that a router or server will be reachable over a mgmt network connected to the host than within the munet network namespace.
python3.11 and up forbid passing coroutines to asyncio.wait() now, so create a list of tasks to pass instead.
Even if the user expects failure, bad json input will fail the test. This was requested from users as the more useful functionality. Really, the only useful reason to support expect_fail on bad json is for testing the framework. Most users with expect_fail=True are looking at comparing some valid json and having the comparison fail, and they want bad input to still be flagged as a failure. If they want to test for bad json they can use a normal `match_step()` test variant and match against the expected "bad" json output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.