[bgpd] CID#62 fix double-free, use-after-free in community_str2com

2006-05-08 Paul Jakma <paul.jakma@sun.com> * bgp_community.c: (community_str2com) Coverity CID#62, fix double-free, use-after-free.
LabNConsulting · May 8, 2006 · 542bcb7 · 542bcb7
1 parent 65ca75e
commit 542bcb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/bgpd/ChangeLog b/bgpd/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-08 Paul Jakma <paul.jakma@sun.com>
+
+	* bgp_community.c: (community_str2com) Coverity CID#62, fix
+	  double-free, use-after-free.
+
 2006-05-04 Paul Jakma <paul.jakma@sun.com>
 
 	* (general) VPNv4 fixes. Certain VPNv4 code was not enabled.

diff --git a/bgpd/bgp_community.c b/bgpd/bgp_community.c
@@ -596,7 +596,7 @@ community_str2com (const char *str)
 	default:
 	  if (com)
 	    community_free (com);
-	  break;
+	  return NULL;
 	}
     } while (str);